From 458fddd772a99b645904a01922bb39af12305a69 Mon Sep 17 00:00:00 2001 From: vicaya Date: Thu, 22 Jan 2026 04:50:23 -0800 Subject: [PATCH] =?UTF-8?q?=E2=9C=85=20Fix=20incorrect=20mocking=20in=20un?= =?UTF-8?q?it=20tests=20(issue=20#1780)=20(#1781)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Yurii Motov --- backend/tests/scripts/test_backend_pre_start.py | 12 ++++++------ backend/tests/scripts/test_test_pre_start.py | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/backend/tests/scripts/test_backend_pre_start.py b/backend/tests/scripts/test_backend_pre_start.py index 631690f..064fca9 100644 --- a/backend/tests/scripts/test_backend_pre_start.py +++ b/backend/tests/scripts/test_backend_pre_start.py @@ -9,11 +9,13 @@ def test_init_successful_connection() -> None: engine_mock = MagicMock() session_mock = MagicMock() - exec_mock = MagicMock(return_value=True) - session_mock.configure_mock(**{"exec.return_value": exec_mock}) + session_mock.__enter__.return_value = session_mock + + select1 = select(1) with ( - patch("sqlmodel.Session", return_value=session_mock), + patch("app.backend_pre_start.Session", return_value=session_mock), + patch("app.backend_pre_start.select", return_value=select1), patch.object(logger, "info"), patch.object(logger, "error"), patch.object(logger, "warn"), @@ -28,6 +30,4 @@ def test_init_successful_connection() -> None: connection_successful ), "The database connection should be successful and not raise an exception." - assert session_mock.exec.called_once_with( - select(1) - ), "The session should execute a select statement once." + session_mock.exec.assert_called_once_with(select1) diff --git a/backend/tests/scripts/test_test_pre_start.py b/backend/tests/scripts/test_test_pre_start.py index a176f38..a4947fd 100644 --- a/backend/tests/scripts/test_test_pre_start.py +++ b/backend/tests/scripts/test_test_pre_start.py @@ -9,11 +9,13 @@ def test_init_successful_connection() -> None: engine_mock = MagicMock() session_mock = MagicMock() - exec_mock = MagicMock(return_value=True) - session_mock.configure_mock(**{"exec.return_value": exec_mock}) + session_mock.__enter__.return_value = session_mock + + select1 = select(1) with ( - patch("sqlmodel.Session", return_value=session_mock), + patch("app.tests_pre_start.Session", return_value=session_mock), + patch("app.tests_pre_start.select", return_value=select1), patch.object(logger, "info"), patch.object(logger, "error"), patch.object(logger, "warn"), @@ -28,6 +30,4 @@ def test_init_successful_connection() -> None: connection_successful ), "The database connection should be successful and not raise an exception." - assert session_mock.exec.called_once_with( - select(1) - ), "The session should execute a select statement once." + session_mock.exec.assert_called_once_with(select1)